Skip to content

Peek card visual #30148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Peek card visual #30148

wants to merge 1 commit into from
+156 −1

Conversation

@razvanlitianu
Copy link
Collaborator

@razvanlitianu razvanlitianu commented Oct 23, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 23, 2025

Fails
🚫 Details needed! Your description section is empty. Adding a bit more context will make reviews smoother.

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
BrowserKit/Sources/ComponentLibrary/SwiftUI/ScrollViewCarouselUX.swift 0.0% 35.0%
BrowserKit/Sources/OnboardingKit/Views/Compact/OnboardingViewCompact.swift 0.0% 35.0%

Generated by 🚫 Danger Swift against df97d6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@razvanlitianu @mobiletest-ci-bot